(feat) Speedup health endpoint #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
can you add a ss of this endpoint working on a request where you set up the config.yaml |
ishaan-jaff
reviewed
Dec 6, 2023
| from concurrent.futures import ThreadPoolExecutor | ||
|
|
||
|
|
||
| logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
what is the purpose of this logger
ishaan-jaff
approved these changes
Dec 6, 2023
|
will merge in 24 hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may continuously monitor the
/healthendpoint in order to send alerts when deployments go down. It's important that the speed of the/healthendpoint does not scale linearly with the number of deployments.This PR does two things.
asyncio.gatherfor all valid models, removing linear time scaling for health checking.